Address BouncyCastle's deprecated AESFastEngine usage #16164
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjacobs
commented
Nov 25, 2024
fjacobs
commented
- Update AESEngine to use the default AES engine, following BouncyCastle's recommendations (see release-1-56 of changelog: https://www.bouncycastle.org/download/bouncy-castle-java/?filter=java%3Drelease-1-56).
- Migrate to the latest API 'newInstance()' method to allow removal of method level @SuppressWarnings("deprecation")
- Remove @SuppressWarnings("deprecation"), as it is not needed anymore
spring-projects-issues
added
the
status: waiting-for-triage
fjacobs
force-pushed
the
updateAESEngine
branch
from
91dc124 to
c1d94bf
Compare
…ngine - Update AESEngine to use the default AES engine, following BouncyCastle's recommendations (see release-1-56 of changelog: https://www.bouncycastle.org/download/bouncy-castle-java/?filter=java%3Drelease-1-56). - Migrate to the latest API 'newInstance()' method to allow removal of @SuppressWarnings("deprecation") - Remove @SuppressWarnings("deprecation")
fjacobs
force-pushed
the
updateAESEngine
branch
from
c1d94bf to
41a3736
Compare
sjohnr
added
in: crypto
|
@fjacobs thanks for opening this. I have reviewed the release notes you referenced and agree that the recommendation in certain cases is to use |
sjohnr
added
the
status: waiting-for-feedback
sjohnr
removed
the
status: waiting-for-feedback
|
@fjacobs do you have any thoughts regarding the above comment? |
sjohnr
added
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.